Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C266017A22 for ; Sun, 12 Oct 2014 03:42:34 +0000 (UTC) Received: (qmail 75088 invoked by uid 500); 12 Oct 2014 03:42:34 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 75041 invoked by uid 500); 12 Oct 2014 03:42:34 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 75028 invoked by uid 99); 12 Oct 2014 03:42:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Oct 2014 03:42:34 +0000 Date: Sun, 12 Oct 2014 03:42:34 +0000 (UTC) From: "Enis Soztutar (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-10462) Recategorize some of the client facing Public / Private interfaces MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-10462: ---------------------------------- Fix Version/s: (was: 0.99.1) 0.99.2 > Recategorize some of the client facing Public / Private interfaces > ------------------------------------------------------------------ > > Key: HBASE-10462 > URL: https://issues.apache.org/jira/browse/HBASE-10462 > Project: HBase > Issue Type: Bug > Components: Client > Reporter: Enis Soztutar > Assignee: Enis Soztutar > Priority: Blocker > Fix For: 2.0.0, 0.99.2 > > Attachments: hbase-10462_wip1.patch > > > We should go over the list of InterfaceAudience.Public interfaces one more to remove those that are NOT indeed public interfaces. > From current trunk, we should change these from public to private: > {code} > ReversedScannerCallable > ReversedClientScanner > ClientScanner (note that ResultScanner is public interface, while ClientScanner should not be) > ClientSmallScanner > TableSnapshotScanner -> We need a way of constructing this since it cannot be constructed from HConnection / HTable. Maybe a basic factory. > {code} > These are not marked: > {code} > Registry, > ZooKeeperRegistry > RpcRetryingCallerFactory > ZooKeeperKeepAliveConnection > AsyncProcess > DelegatingRetryingCallable > HConnectionKey > MasterKeepAliveConnection > MultiServerCallable > {code} > We can think about making these public interface: > {code} > ScanMetrics > {code} > Add javadoc to: > {code} > Query > {code} > We can add a test to find out all classes in client package to check for interface mark. > We can extend this to brainstorm on the preferred API options. We probably want the clients to use HTableInterface, instead of HTable everywhere. HConnectionManager comes with bazillion methods which are not intended for public use, etc. > Raising this as blocker to 1.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)