Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EC02117F65 for ; Fri, 3 Oct 2014 03:31:35 +0000 (UTC) Received: (qmail 77314 invoked by uid 500); 3 Oct 2014 03:31:35 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 76797 invoked by uid 500); 3 Oct 2014 03:31:34 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 76780 invoked by uid 99); 3 Oct 2014 03:31:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Oct 2014 03:31:34 +0000 Date: Fri, 3 Oct 2014 03:31:34 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (HBASE-10153) improve VerifyReplication to compute BADROWS more accurately MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved HBASE-10153. ---------------------------- Resolution: Fixed Thanks for the patch, Jianwei Thanks for the reviews. > improve VerifyReplication to compute BADROWS more accurately > ------------------------------------------------------------ > > Key: HBASE-10153 > URL: https://issues.apache.org/jira/browse/HBASE-10153 > Project: HBase > Issue Type: Improvement > Components: Operability, Replication > Affects Versions: 0.94.14 > Reporter: cuijianwei > Assignee: cuijianwei > Fix For: 2.0.0, 0.98.7, 0.99.1 > > Attachments: 10153-0.98.txt, 10153-v2-trunk.txt, HBASE-10153-0.94-v1.patch, HBASE-10153-trunk.patch > > > VerifyReplicaiton could compare the source table with its peer table and compute BADROWS. However, the current BADROWS computing method might not be accurate enough. For example, if source table contains rows as {r1, r2, r3, r4} and peer table contains rows as {r1, r3, r4} BADROWS will be 3 because 'r2' in source table will make all the later row comparisons fail. Will it be better if the BADROWS is computed to 1 in this situation? Maybe, we can compute the BADROWS more accurately in merge comparison? -- This message was sent by Atlassian JIRA (v6.3.4#6332)