Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C30181767C for ; Fri, 31 Oct 2014 05:26:35 +0000 (UTC) Received: (qmail 85902 invoked by uid 500); 31 Oct 2014 05:26:35 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 85855 invoked by uid 500); 31 Oct 2014 05:26:35 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 85842 invoked by uid 99); 31 Oct 2014 05:26:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Oct 2014 05:26:35 +0000 Date: Fri, 31 Oct 2014 05:26:35 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-9003) TableMapReduceUtil should not rely on org.apache.hadoop.util.JarFinder#getJar MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-9003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191384#comment-14191384 ] Hudson commented on HBASE-9003: ------------------------------- FAILURE: Integrated in HBase-TRUNK #5728 (See [https://builds.apache.org/job/HBase-TRUNK/5728/]) HBASE-9003 TableMapReduceUtil should not rely on org.apache.hadoop.util.JarFinder#getJar (Esteban Gutierrez) (stack: rev a71dd16a70e9a594e6aa24f69eb7b1d279273ca8) * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/hadoopbackport/TestJarFinder.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/hadoopbackport/JarFinder.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/JarFinder.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestJarFinder.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java > TableMapReduceUtil should not rely on org.apache.hadoop.util.JarFinder#getJar > ----------------------------------------------------------------------------- > > Key: HBASE-9003 > URL: https://issues.apache.org/jira/browse/HBASE-9003 > Project: HBase > Issue Type: Bug > Components: mapreduce > Reporter: Esteban Gutierrez > Assignee: Esteban Gutierrez > Fix For: 2.0.0, 0.99.2 > > Attachments: HBASE-9003.v0.patch, HBASE-9003.v1.patch, HBASE-9003.v2.patch, HBASE-9003.v2.patch, HBASE-9003.v3.patch > > > This is the problem: {{TableMapReduceUtil#addDependencyJars}} relies on {{org.apache.hadoop.util.JarFinder}} if available to call {{getJar()}}. However {{getJar()}} uses File.createTempFile() to create a temporary file under {{hadoop.tmp.dir}}{{/target/test-dir}}. Due HADOOP-9737 the created jar and its content is not purged after the JVM is destroyed. Since most configurations point {{hadoop.tmp.dir}} under {{/tmp}} the generated jar files get purged by {{tmpwatch}} or a similar tool, but boxes that have {{hadoop.tmp.dir}} pointing to a different location not monitored by {{tmpwatch}} will pile up a collection of jars causing all kind of issues. Since {{JarFinder#getJar}} is not a public API from Hadoop (see [~tucu00] comment on HADOOP-9737) we shouldn't use that as part of {{TableMapReduceUtil}} in order to avoid this kind of issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)