hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12392) Incorrect implementation of CompactionRequest.isRetainDeleteMarkers
Date Fri, 31 Oct 2014 09:50:36 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191647#comment-14191647
] 

ramkrishna.s.vasudevan commented on HBASE-12392:
------------------------------------------------

Should we wait for [~jmhsieh] +1? Or can we commit this. Change is fine anyway.

> Incorrect implementation of CompactionRequest.isRetainDeleteMarkers
> -------------------------------------------------------------------
>
>                 Key: HBASE-12392
>                 URL: https://issues.apache.org/jira/browse/HBASE-12392
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>    Affects Versions: hbase-11339
>            Reporter: Jingcheng Du
>            Assignee: Jingcheng Du
>            Priority: Critical
>             Fix For: hbase-11339
>
>         Attachments: HBASE-12392.diff
>
>
> Now in the implementation of the isRetainDeleteMarkers method, the code look like,
> {code}
> return (this.retainDeleteMarkers != null) ? this.retainDeleteMarkers.booleanValue()
>         : isAllFiles();
> {code}
> It means for a major compaction in a normal store, this method returns true. Consequently
the delete marks could not be deleted in the major compaction, which leads the unit test TestKeepDeletes
fails.
> The correct implementation should be,
> {code}
> return (this.retainDeleteMarkers != null) ? this.retainDeleteMarkers.booleanValue()
>         : !isAllFiles();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message