hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12358) Create ByteBuffer backed Cell
Date Tue, 28 Oct 2014 21:12:37 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187476#comment-14187476

stack commented on HBASE-12358:

Its not a Buffer backed Cell, its a ByteBufferBackedCell so change the name BufferBackedCell?

HBASE-12224 has nothing in it on why we'd want ByteBuffer readers.  Can we do up one pager
on what we are about (Read using DBBs?) and why DBB?

Cell is broke for DBBs because it presumes you can get backing array?  Should we add an hasArray

Looking at the Interface, we are going to be creating a BB each time we want to look at a
few bytes or do a family compare.  We want to do that?  Or what are the ops we might want
to do?  If all compares could we give the Cells to compare to comparator and it then internal
to itself does the right thing if hasArray is false, etc.

Good stuff

> Create ByteBuffer backed Cell
> -----------------------------
>                 Key: HBASE-12358
>                 URL: https://issues.apache.org/jira/browse/HBASE-12358
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0, 0.99.2
>         Attachments: HBASE-12358.patch
> As part of HBASE-12224 we wanted a Cell that is backed by BB.  Changing the core Cell
impl would not be needed as it is used in server only.  So we will create a BB backed Cell
and use it in the Server side read path. This JIRA just creates an interface that extends
Cell and adds the needed API.
> The getTimeStamp and getTypebyte() can still refer to the original Cell API only.  The
getXXxOffset() and getXXXLength() can also refer to the original Cell only.

This message was sent by Atlassian JIRA

View raw message