hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12347) Fix the edge case where Hadoop QA's parsing of attached patches breaks the JIRA status checker in dev-support/rebase_all_git_branches.sh
Date Mon, 27 Oct 2014 07:27:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184909#comment-14184909
] 

Hadoop QA commented on HBASE-12347:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12677246/HBASE-12347.patch
  against trunk revision .
  ATTACHMENT ID: 12677246

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFilesSplitRecovery

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11470//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11470//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11470//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11470//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11470//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11470//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11470//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11470//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11470//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11470//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11470//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11470//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11470//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11470//console

This message is automatically generated.

> Fix the edge case where Hadoop QA's parsing of attached patches breaks the JIRA status
checker in dev-support/rebase_all_git_branches.sh
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12347
>                 URL: https://issues.apache.org/jira/browse/HBASE-12347
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>            Reporter: Misty Stanley-Jones
>            Assignee: Misty Stanley-Jones
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-12347.patch
>
>
> The rebase_all_hbase_branches.sh script is unable to detect that HBASE-12207 is closed,
because for that one JIRA, the curl command that detects the status is returning the status,
but also the text from Hadoop QA for each patch it has evaluated on the JIRA:
> {code}
> $ curl -s https://issues.apache.org/jira/browse/HBASE-12207 | grep resolution-val
>                 <span id="resolution-val" class="value resolved" >
>     +		jira_status=$(curl -s $jira_url/$jira|grep resolution-val|sed -e "s/.*class=\"value\
//"|cut -d'"' -f 1)<br/>
>     +		jira_status=$(curl -s $jira_url/$jira|grep resolution-val|sed -e "s/.*class=\"value\
//"|cut -d'"' -f 1)
>     +		jira_status=$(curl -s $jira_url/$jira|grep resolution-val|sed -e "s/.*class=\"value\
//"|cut -d'"' -f 1)<br/>
>     +		jira_status=$(curl -s $jira_url/$jira|grep resolution-val|sed -e "s/.*class=\"value\
//"|cut -d'"' -f 1)
>     +		jira_status=$(curl -s $jira_url/$jira|grep resolution-val|sed -e "s/.*class=\"value\
//"|cut -d'"' -f 1)<br/>
>     +		jira_status=$(curl -s $jira_url/$jira|grep resolution-val|sed -e "s/.*class=\"value\
//"|cut -d'"' -f 1)
>     +		jira_status=$(curl -s $jira_url/$jira|grep resolution-val|sed -e "s/.*class=\"value\
//"|cut -d'"' -f 1)<br/>
>     +		jira_status=$(curl -s $jira_url/$jira|grep resolution-val|sed -e "s/.*class=\"value\
//"|cut -d'"' -f 1)
> {code}
> All but the top line of output are from parsing comments from Hadoop QA. I think this
is an edge case that will only to patches against that section of dev-support/rebase_all_git_branches.sh.
However, I'm not sure the cleanest way to fix it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message