hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12334) Handling of DeserializationException causes needless retry on failure
Date Fri, 24 Oct 2014 21:06:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183487#comment-14183487
] 

Andrew Purtell commented on HBASE-12334:
----------------------------------------

lgtm, as long it's committed to master and branch-1 too. 

> Handling of DeserializationException causes needless retry on failure
> ---------------------------------------------------------------------
>
>                 Key: HBASE-12334
>                 URL: https://issues.apache.org/jira/browse/HBASE-12334
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.7
>            Reporter: James Taylor
>            Assignee: Lars Hofhansl
>              Labels: Phoenix
>             Fix For: 2.0.0, 0.98.8, 0.99.2
>
>         Attachments: 12334-0.98.txt
>
>
> If an unexpected exception occurs when deserialization occurs for a custom filter, the
exception gets wrapped in a DeserializationException. Since this exception is in turn wrapped
in an IOException, the many loop retry logic kicks in. The net effect is that this same deserialization
error occurs again and again as the retries occur, just causing the client to wait needlessly.
> IMO, either the parseFrom methods should be allowed to throw whatever type of IOException
they'd like, in which case they could throw a DoNotRetryIOException, or a DeserializationException
should be wrapped in a DoNotRetryIOException.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message