hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12327) MetricsHBaseServerSourceFactory#createContextName has wrong conditions
Date Fri, 24 Oct 2014 05:53:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182472#comment-14182472
] 

Hadoop QA commented on HBASE-12327:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12676842/HBASE-12327.2.patch
  against trunk revision .
  ATTACHMENT ID: 12676842

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11459//console

This message is automatically generated.

> MetricsHBaseServerSourceFactory#createContextName has wrong conditions
> ----------------------------------------------------------------------
>
>                 Key: HBASE-12327
>                 URL: https://issues.apache.org/jira/browse/HBASE-12327
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Sanghyun Yun
>         Attachments: HBASE-12327.2.patch, HBASE-12327.patch
>
>
> MetricsHBaseServerSourceFactory#createContextName has wrong conditions.
> It checks serverName contains "HMaster" or "HRegion".
> {code:title=MetricsHBaseServerSourceFactory.java}
> ...
>   protected static String createContextName(String serverName) {
>     if (serverName.contains("HMaster")) {
>       return "Master";
>     } else if (serverName.contains("HRegion")) {
>       return "RegionServer";
>     }
>     return "IPC";
>   }
> ...
> {code}
> But, passed serverName actually contains "master" or "regionserver" by HMaster#getProcessName
and HRegionServer#getProcessName.
> {code:title=HMaster.java}
> ...
>   // MASTER is name of the webapp and the attribute name used stuffing this
>   //instance into web context.
>   public static final String MASTER = "master";
> ...
>   protected String getProcessName() {
>     return MASTER;
>   }
> ...
> {code}
> {code:title=HRegionServer.java}
> ...
>   /** region server process name */
>   public static final String REGIONSERVER = "regionserver";
> ...
>   protected String getProcessName() {
>     return REGIONSERVER;
>   }
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message