hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12313) Redo the hfile index length optimization so cell-based rather than serialized KV key
Date Mon, 27 Oct 2014 17:14:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14185429#comment-14185429
] 

Hadoop QA commented on HBASE-12313:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12677337/12313v6.txt
  against trunk revision .
  ATTACHMENT ID: 12677337

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 36 new or modified
tests.

    {color:red}-1 javac{color}.  The patch appears to cause mvn compile goal to fail.

    Compilation errors resume:
    [ERROR] COMPILATION ERROR : 
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java:[2218,19]
[DepAnn] Deprecated item is not annotated with @Deprecated
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java:[2516,16]
[DepAnn] Deprecated item is not annotated with @Deprecated
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:compile
(default-compile) on project hbase-common: Compilation failure: Compilation failure:
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java:[2218,19]
[DepAnn] Deprecated item is not annotated with @Deprecated
[ERROR] (see http://code.google.com/p/error-prone/wiki/DepAnn)
[ERROR] Did you mean '@Deprecated'?
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java:[2516,16]
[DepAnn] Deprecated item is not annotated with @Deprecated
[ERROR] (see http://code.google.com/p/error-prone/wiki/DepAnn)
[ERROR] Did you mean '@Deprecated'?
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following
articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :hbase-common
    

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11477//console

This message is automatically generated.

> Redo the hfile index length optimization so cell-based rather than serialized KV key
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-12313
>                 URL: https://issues.apache.org/jira/browse/HBASE-12313
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: stack
>            Assignee: stack
>         Attachments: 0001-HBASE-12313-Redo-the-hfile-index-length-optimization.patch,
0001-HBASE-12313-Redo-the-hfile-index-length-optimization.patch, 0001-HBASE-12313-Redo-the-hfile-index-length-optimization.patch,
0001-HBASE-12313-Redo-the-hfile-index-length-optimization.patch, 0001-HBASE-12313-Redo-the-hfile-index-length-optimization.patch,
12313v5.txt, 12313v6.txt
>
>
> Trying to remove API that returns the 'key' of a KV serialized into a byte array is thorny.
> I tried to move over the first and last key serializations and the hfile index entries
to be cell but patch was turning massive.  Here is a smaller patch that just redoes the optimization
that tries to find 'short' midpoints between last key of last block and first key of next
block so it is Cell-based rather than byte array based (presuming Keys serialized in a certain
way).  Adds unit tests which we didn't have before.
> Also remove CellKey.  Not needed... at least not yet.  Its just utility for toString.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message