hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12282) Ensure Cells and its implementations work with Buffers also
Date Thu, 30 Oct 2014 04:35:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14189633#comment-14189633
] 

ramkrishna.s.vasudevan commented on HBASE-12282:
------------------------------------------------

bq.The impl of BB backed Cell will throw UnsupportedOpException when calling getxxxArray()
right?
Now this would mean that all the KeyValueScanner would be only Cells. And every where we need
to use getXXXBuffer() we will be using hasArray and based on that use the relevant API.  
If we change to BufferedBackedCell in the read path every where then the cases of memstore
will be problematic.  Hence we will go with the approach where all the comparators would decide
on how the array or buffer should be used.  

> Ensure Cells and its implementations work with Buffers also
> -----------------------------------------------------------
>
>                 Key: HBASE-12282
>                 URL: https://issues.apache.org/jira/browse/HBASE-12282
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>    Affects Versions: 0.99.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: HBASE-12224_2.patch
>
>
> This issue can be used to brainstorm and then do the necessary changes for the offheap
work.  All impl of cells deal with byte[] but when we change the Hfileblocks/Readers to work
purely with Buffers then the byte[] usage would mean that always the data is copied to the
onheap.  Cell may need some interface change to implement this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message