hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12282) Ensure Cells and its implementations work with Buffers also
Date Wed, 29 Oct 2014 06:25:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188062#comment-14188062

stack commented on HBASE-12282:

I took a look at this already up at https://issues.apache.org/jira/browse/HBASE-12282?focusedCommentId=14178619&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14178619

Here is some more comment:

Looking again at Cell changes, rather than change Cell, could we do something like hasArray
from BB in Cell and if it does not have array (because it DBB), then we do stuff like Anoop
is doing to do compares of DBBs where unsafe or by offset into the DBB rather than array references?

CellComparator is still byte [] based in this patch?  Still gets the arrays from Cell.

Why would we do this:

+      ByteBuffer wrapBuf = ByteBuffer.wrap(buf);
+      return ByteBufferUtils.equals(left.getValueBuffer(), left.getValueOffset(),
+          left.getValueLength(), wrapBuf, 0, wrapBuf.capacity());

Why not pass in two BBs into BBU and let it figure it out?

> Ensure Cells and its implementations work with Buffers also
> -----------------------------------------------------------
>                 Key: HBASE-12282
>                 URL: https://issues.apache.org/jira/browse/HBASE-12282
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>    Affects Versions: 0.99.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0, 0.99.2
>         Attachments: HBASE-12224_2.patch
> This issue can be used to brainstorm and then do the necessary changes for the offheap
work.  All impl of cells deal with byte[] but when we change the Hfileblocks/Readers to work
purely with Buffers then the byte[] usage would mean that always the data is copied to the
onheap.  Cell may need some interface change to implement this.

This message was sent by Atlassian JIRA

View raw message