hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12281) ClonedPrefixTreeCell should implement HeapSize
Date Tue, 21 Oct 2014 10:18:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178234#comment-14178234
] 

Anoop Sam John commented on HBASE-12281:
----------------------------------------

{code}
List<Tag> tags = Tag.asList(getTagsArray(), getTagsOffset(), getTagsLength());
+      if (tags != null) {
+        List<String> tagsString = new ArrayList<String>();
+        for (Tag t : tags) {
+          tagsString.add((t.getType()) + ":" + Bytes.toStringBinary(t.getValue()));
+        }
+      }
{code}
tagsString unused.  We dont need to write tags details in toString. Just remove above code
block.

{code}
return FIXED_OVERHEAD + rowLength + famLength + qualLength + valLength + tagsLength
+          + KeyValue.TIMESTAMP_TYPE_SIZE;
{code}
FIXED_OVERHEAD already includes the long and byte type size corresponding to rs and type.
 KeyValue.TIMESTAMP_TYPE_SIZE addition not needed no?

> ClonedPrefixTreeCell should implement HeapSize
> ----------------------------------------------
>
>                 Key: HBASE-12281
>                 URL: https://issues.apache.org/jira/browse/HBASE-12281
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.99.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0, 0.99.2
>
>         Attachments: HBASE-12281.patch, HBASE-12281_1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message