hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Madhan Neethiraj (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12277) Refactor bulkLoad methods in AccessController to its own interface
Date Fri, 17 Oct 2014 19:13:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175408#comment-14175408
] 

Madhan Neethiraj commented on HBASE-12277:
------------------------------------------

bq. {quote}
We could do this as a short term measure.
Longer term, as I understand it, we will be moving SecureBulkLoadEndpoint first and then the
equivalents of the AccessController and VisibilityController into core code. This will ultimately
resolve the stated issue.
It might be better to resolve this issue in the short term as well by moving SecureBulkLoadEndpoint
functionality into core code right away.
{quote}

[~apurtell] Thanks for reviewing and your comments. Moving SecureBulkLoadEndPoint to core
will probably have a wider impact, which can be considered as a longer term update.

The current fix is very isolated to decoupling AccessController from SecureBulkLoadEndPoint.
I have the patch uploaded. Can you please review?


> Refactor bulkLoad methods in AccessController to its own interface
> ------------------------------------------------------------------
>
>                 Key: HBASE-12277
>                 URL: https://issues.apache.org/jira/browse/HBASE-12277
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Madhan Neethiraj
>         Attachments: 0001-HBASE-12277-Refactored-bulk-load-methods-from-Access.patch,
0002-HBASE-12277-License-text-added-to-the-newly-created-.patch, HBASE-12277-v2.patch, HBASE-12277.patch
>
>
> SecureBulkLoadEndPoint references couple of methods, prePrepareBulkLoad() and preCleanupBulkLoad(),
implemented in AccessController i.e. direct coupling between AccessController and SecureBuikLoadEndPoint
classes.
> SecureBulkLoadEndPoint assumes presence of AccessController in secure-cluster. If HBase
is configured with another coprocessor for access-control, SecureBulkLoadEndPoint fails with
NPE.
> To remove this direct coupling, bulk-load related methods in AccessController should
be refactored to an interface; and have AccessController implement this interfaces. SecureBulkLoadEndPoint
should then look for coprocessors that implement this interface, instead of directly looking
for AccessController.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message