hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12277) Refactor bulkLoad methods in AccessController to its own interface
Date Fri, 17 Oct 2014 07:18:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14174803#comment-14174803
] 

Hadoop QA commented on HBASE-12277:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12675430/HBASE-12277-v2.patch
  against trunk revision .
  ATTACHMENT ID: 12675430

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 3 warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

     {color:red}-1 core zombie tests{color}.  There are 2 zombie test(s): 	at org.apache.openjpa.persistence.lockmgr.TestMixedLockManagerFindPermutation.testFindWritePessimisticRead(TestMixedLockManagerFindPermutation.java:120)
	at org.apache.openjpa.persistence.test.AbstractPersistenceTestCase.runTest(AbstractPersistenceTestCase.java:579)
	at org.apache.openjpa.persistence.test.AbstractPersistenceTestCase.runBare(AbstractPersistenceTestCase.java:566)
	at org.apache.openjpa.persistence.test.AbstractPersistenceTestCase.runBare(AbstractPersistenceTestCase.java:542)
	at org.apache.openjpa.persistence.test.AbstractPersistenceTestCase.run(AbstractPersistenceTestCase.java:206)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11389//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11389//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11389//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11389//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11389//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11389//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11389//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11389//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11389//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11389//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11389//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11389//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11389//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11389//console

This message is automatically generated.

> Refactor bulkLoad methods in AccessController to its own interface
> ------------------------------------------------------------------
>
>                 Key: HBASE-12277
>                 URL: https://issues.apache.org/jira/browse/HBASE-12277
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Madhan Neethiraj
>         Attachments: 0001-HBASE-12277-Refactored-bulk-load-methods-from-Access.patch,
0002-HBASE-12277-License-text-added-to-the-newly-created-.patch, HBASE-12277-v2.patch, HBASE-12277.patch
>
>
> SecureBulkLoadEndPoint references couple of methods, prePrepareBulkLoad() and preCleanupBulkLoad(),
implemented in AccessController i.e. direct coupling between AccessController and SecureBuikLoadEndPoint
classes.
> SecureBulkLoadEndPoint assumes presence of AccessController in secure-cluster. If HBase
is configured with another coprocessor for access-control, SecureBulkLoadEndPoint fails with
NPE.
> To remove this direct coupling, bulk-load related methods in AccessController should
be refactored to an interface; and have AccessController implement this interfaces. SecureBulkLoadEndPoint
should then look for coprocessors that implement this interface, instead of directly looking
for AccessController.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message