hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niels Basjes (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-12272) Generate Thrift code through maven
Date Thu, 16 Oct 2014 18:30:34 GMT

     [ https://issues.apache.org/jira/browse/HBASE-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Niels Basjes updated HBASE-12272:
---------------------------------
    Attachment: HBASE-12272-2014-10-16-v4.patch

Changes compared to v3:
- Removed property activation (pom.xml and documentation)
- Missed a few spots where ${thrift.path} should be used.

Question: This still leaves the line too long (> 100 chars) in the pom.xml caused by the
very long path where the thrift files are located. What is the desired way to handle this?
Or is this an acceptable case?


> Generate Thrift code through maven
> ----------------------------------
>
>                 Key: HBASE-12272
>                 URL: https://issues.apache.org/jira/browse/HBASE-12272
>             Project: HBase
>          Issue Type: Improvement
>          Components: build, documentation, Thrift
>            Reporter: Niels Basjes
>         Attachments: HBASE-12272-2014-10-15-v1-PREVIEW.patch, HBASE-12272-2014-10-16-v2.patch,
HBASE-12272-2014-10-16-v3.patch, HBASE-12272-2014-10-16-v4.patch
>
>
> The generated thrift code is currently under source control.
> This should be generated automatically during the build.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message