hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12267) Replace HTable constructor in mapreduce.* classes with ConnectionFactory
Date Mon, 20 Oct 2014 15:23:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176972#comment-14176972
] 

stack commented on HBASE-12267:
-------------------------------

We need this [~sduskis]?

setClearBufferOnFail

When would it be used?

FYI, we don't put try and first statement in clause on one line as below

   try (Connection conn = ConnectionFactory.createConnection(conf);

Is there an accompanying finally to match the above try in IntegrationTestBulkLoad.java? 
(Might be just the way this patch rendors....)

Just remove the below

	//    private Table table;

Skimmed the patch. LGTM.

> Replace HTable constructor in mapreduce.* classes with ConnectionFactory 
> -------------------------------------------------------------------------
>
>                 Key: HBASE-12267
>                 URL: https://issues.apache.org/jira/browse/HBASE-12267
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Solomon Duskis
>            Assignee: Solomon Duskis
>             Fix For: 2.0.0, 0.99.2
>
>         Attachments: HBASE-12267.patch, HBASE-12267_v2.patch, HBASE-12267_v3.patch, HBASE-12267_v4.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message