hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12265) HBase shell 'show_filters' points to internal Facebook URL
Date Wed, 15 Oct 2014 17:42:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172654#comment-14172654
] 

Hadoop QA commented on HBASE-12265:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12675020/HBASE-12265.patch
  against trunk revision .
  ATTACHMENT ID: 12675020

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation patch
that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11355//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11355//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11355//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11355//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11355//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11355//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11355//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11355//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11355//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11355//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11355//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11355//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11355//console

This message is automatically generated.

> HBase shell 'show_filters' points to internal Facebook URL
> ----------------------------------------------------------
>
>                 Key: HBASE-12265
>                 URL: https://issues.apache.org/jira/browse/HBASE-12265
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>            Reporter: Niels Basjes
>            Assignee: Andrew Purtell
>            Priority: Trivial
>              Labels: documentation, help
>             Fix For: 2.0.0, 0.98.8, 0.99.2
>
>         Attachments: HBASE-12265.patch
>
>
> In the HBase shell the output of the show_filters command starts with this:
> {code}
> hbase(main):001:0> show_filters
> Documentation on filters mentioned below can be found at: https://our.intern.facebook.com/intern/wiki/index.php/HBase/Filter_Language
> ColumnPrefixFilter
> TimestampsFilter
> ...
> {code}
> This documentation link cannot be reached by me. It seems to be an internal link to a
wiki that can only be reached by Facebook employees.
> This link is in this file in two places 
> hbase-shell/src/main/ruby/shell/commands/show_filters.rb
> So far I have not been able to find the 'right' page to point to (I did a quick check
of the apache wiki and the hbase book).
> So either remove the link or add a section to the hbase book and point there. I think
the latter (creating documentation) is the best solution.
> Perhaps Facebook is willing to donate the apparently existing pages?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message