hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
Date Tue, 21 Oct 2014 03:41:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177891#comment-14177891
] 

Lars Hofhansl commented on HBASE-12261:
---------------------------------------

{{mvn test -Dtest=<test>}} is also broken (even after HBASE-12294):
{code}
HBase - Checkstyle ................................ FAILURE [0.477s]
...
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test
(default-test) on project hbase-checkstyle: No tests were executed!  (Set -DfailIfNoTests=false
to ignore this error.) -> [Help 1]
{code}

Meh... Maven is so obtuse.
Maybe it's best to roll this back for now?

> Add checkstyle to HBase build process
> -------------------------------------
>
>                 Key: HBASE-12261
>                 URL: https://issues.apache.org/jira/browse/HBASE-12261
>             Project: HBase
>          Issue Type: Bug
>          Components: build, site
>    Affects Versions: 2.0.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>             Fix For: 2.0.0, 0.98.8, 0.99.2
>
>         Attachments: 0001-Add-checkstyle.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch,
0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch
>
>
> We should add checkstyle to hadoop qa for our builds. That would free committers up from
checking patches for stylistic issues and leave them free to check the real meat of the patches.
> Additionally we should have the check for empty try catch blocks running so that we can't
regress on catching exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message