hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
Date Wed, 15 Oct 2014 16:23:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172532#comment-14172532
] 

Andrew Purtell commented on HBASE-12261:
----------------------------------------

+1

I like that we can toggle on or off individual checks in the checkstyle.xml control file

> Add checkstyle to HBase build process
> -------------------------------------
>
>                 Key: HBASE-12261
>                 URL: https://issues.apache.org/jira/browse/HBASE-12261
>             Project: HBase
>          Issue Type: Bug
>          Components: build, site
>    Affects Versions: 2.0.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>         Attachments: 0001-Add-checkstyle.patch
>
>
> We should add checkstyle to hadoop qa for our builds. That would free committers up from
checking patches for stylistic issues and leave them free to check the real meat of the patches.
> Additionally we should have the check for empty try catch blocks running so that we can't
regress on catching exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message