hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12223) MultiTableInputFormatBase.getSplits is too slow
Date Mon, 13 Oct 2014 16:26:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169475#comment-14169475
] 

Hadoop QA commented on HBASE-12223:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12674454/HBASE-12223.patch
  against trunk revision .
  ATTACHMENT ID: 12674454

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 4 warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +                  if ((startRow.length == 0 || keys.getSecond()[i].length == 0 || Bytes.compareTo(startRow,
+                          keys.getSecond()[i]) < 0) && (stopRow.length == 0 ||
Bytes.compareTo(stopRow,
+                      byte[] splitStart = startRow.length == 0 || Bytes.compareTo(keys.getFirst()[i],
+                      byte[] splitStop = (stopRow.length == 0 || Bytes.compareTo(keys.getSecond()[i],
+                              stopRow) <= 0) && keys.getSecond()[i].length >
0 ? keys.getSecond()[i] : stopRow;
+                      String regionLocation = table.getRegionLocation(keys.getFirst()[i],
false).getHostname();
+                      InputSplit split = new TableSplit(Bytes.toBytes(tableNameStr), scan,
splitStart,

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11326//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11326//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11326//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11326//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11326//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11326//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11326//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11326//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11326//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11326//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11326//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11326//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11326//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11326//console

This message is automatically generated.

> MultiTableInputFormatBase.getSplits is too slow
> -----------------------------------------------
>
>                 Key: HBASE-12223
>                 URL: https://issues.apache.org/jira/browse/HBASE-12223
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 0.94.15
>            Reporter: shanwen
>            Priority: Minor
>             Fix For: 2.0.0, 0.98.8, 0.94.25, 0.99.2
>
>         Attachments: HBASE-12223.patch
>
>
> when use Multiple scan,getSplits is too slow,800 scans take five minutes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message