hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12202) Support DirectByteBuffer usage in HFileBlock
Date Wed, 15 Oct 2014 00:11:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171743#comment-14171743
] 

stack commented on HBASE-12202:
-------------------------------

Interesting. ByteBufferInputStream seems to be a pretty common invention if I poke on net.
 Thought there was one already in hadoop but no....

Generally I think this unnecessary... it is going to happen anyways?

67	    if (b == null) {
68	      throw new NullPointerException();

... and this?

    } else if (off < 0 || len < 0 || len > b.length - off) {
70	      throw new IndexOutOfBoundsException();
71	    }


Looks good to me.  You think it can work w/ offheap BBs now?




> Support DirectByteBuffer usage in HFileBlock
> --------------------------------------------
>
>                 Key: HBASE-12202
>                 URL: https://issues.apache.org/jira/browse/HBASE-12202
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0, 0.99.2
>
>         Attachments: HBASE-12202.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message