hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-12148) Remove TimeRangeTracker as point of contention when many threads writing a Store
Date Wed, 22 Oct 2014 20:57:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180519#comment-14180519
] 

Lars Hofhansl edited comment on HBASE-12148 at 10/22/14 8:57 PM:
-----------------------------------------------------------------

Here's another thought? Why does TimerangeTracker need to be synchronized at all?
It's only used in StoreFile.writer. Are we ever appending to the *same* StoreFile from multiple
threads? And if so, maybe that's the place to synchronize - after all in a StoreFile we need
to guarantee the order of KVs, so writing threads would need to coordinate anyway.

Can we simply remove the synchronization?



was (Author: lhofhansl):
Here's another thought? Why does TimerangeTracker need to be synchronized at all?
It's only used StoreFile.writer. Are we ever appending to the *same* StoreFile from multiple
threads? And if so, maybe that's the place to synchronize - after all in a StoreFile we need
guarantee order of KVs, so writing threads would need to coordinate anyway.

Can we simply remove the synchronization?


> Remove TimeRangeTracker as point of contention when many threads writing a Store
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-12148
>                 URL: https://issues.apache.org/jira/browse/HBASE-12148
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Performance
>    Affects Versions: 2.0.0, 0.99.1
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0, 0.98.8, 0.99.2
>
>         Attachments: 0001-In-AtomicUtils-change-updateMin-and-updateMax-to-ret.patch,
12148.addendum.txt, 12148.txt, 12148.txt, 12148v2.txt, 12148v2.txt, Screen Shot 2014-10-01
at 3.39.46 PM.png, Screen Shot 2014-10-01 at 3.41.07 PM.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message