hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
Date Wed, 01 Oct 2014 10:24:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154638#comment-14154638
] 

Hudson commented on HBASE-12112:
--------------------------------

FAILURE: Integrated in HBase-TRUNK #5598 (See [https://builds.apache.org/job/HBase-TRUNK/5598/])
HBASE-12112 Avoid KeyValueUtil#ensureKeyValue some more simple cases. (anoopsamjohn: rev 4fac4c1ba6fa1a0b30a798d3d1f2a8f803a5c531)
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFileManager.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV3.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/CellKey.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallReversedScanner.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileManager.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallScanner.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java


> Avoid KeyValueUtil#ensureKeyValue some more simple cases
> --------------------------------------------------------
>
>                 Key: HBASE-12112
>                 URL: https://issues.apache.org/jira/browse/HBASE-12112
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0, 0.99.1
>
>         Attachments: HBASE-12112.patch, HBASE-12112_V2.patch, HBASE-12112_V2.patch, HBASE-12112_V4.patch,
HBASE-12112_V4.patch
>
>
> This include fixes with
> - Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell)
> - Printing the key portion of a cell (rk+cf+q+ts+type). These are in Exception messages
> - HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to cell#getxxx() which
involves bytes copying. This is not a hot area still we can avoid as much usage of deprecated
methods as possible in core code. I believe these bytes copying methods are used in many other
parts and later we can try fixing those as per area importance
> - Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message