hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11973) The url of the token file location set by IntegrationTestImportTsv should point to the localfs
Date Thu, 02 Oct 2014 00:24:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155866#comment-14155866
] 

Andrew Purtell commented on HBASE-11973:
----------------------------------------

This is a 0.98 patch. I'm not finding where to apply this in trunk. The string "CREDENTIALS_LOCATION"
doesn't appear anywhere under hbase-it/ according to grep. We have test code in 0.98 that
does not exist in branch-1 or master.

{code}
07caf4bf (Zhihong Yu     2014-05-20 18:27:32 +0000 263)       String fileLocation = System.getenv(UserGroupInformation.HADOOP_TOKEN_FILE_LOCATION);
07caf4bf (Zhihong Yu     2014-05-20 18:27:32 +0000 264)       conf.set(ImportTsv.CREDENTIALS_LOCATION,
fileLocation);
{code}

This commit is
{noformat}
commit 07caf4bf8e77b26469c8bc49eaa278c3a4047612
Author: Zhihong Yu <tedyu@apache.org>
Date:   Tue May 20 18:27:32 2014 +0000

    HBASE-11104 IntegrationTestImportTsv#testRunFromOutputCommitter misses credential initialization
(Vandana)
{noformat}

However this unit test case was later removed from branch-1 and master by HBASE-12008:

{noformat}
commit a36ffdaff7f67e92c7f8f05c480fad1dfc28ef02
Author: Nick Dimiduk <ndimiduk@apache.org>
Date:   Mon Sep 29 13:29:28 2014 -0700

    HBASE-12008 Remove IntegrationTestImportTsv#testRunFromOutputCommitter

 hbase-it/src/test/java/org/apache/hadoop/hbase/mapreduce/IntegrationTestImportTsv.java |
173 ---------------------------------------------------------------
 1 file changed, 173 deletions(-)
{noformat}

Therefore I would like to reject the patch on this issue and apply HBASE-12008 to 0.98 instead.

[~ted_yu] [~ndimiduk] [~devaraj] [~stack]

> The url of the token file location set by IntegrationTestImportTsv should point to the
localfs
> ----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-11973
>                 URL: https://issues.apache.org/jira/browse/HBASE-11973
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.98.7
>
>         Attachments: 11973-1.txt
>
>
> The location of the token file is on the local filesystem. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message