hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11912) Catch some bad practices at compile time with error-prone
Date Mon, 13 Oct 2014 18:18:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169683#comment-14169683

Andrew Purtell commented on HBASE-11912:

Yes. I'm planning to look at this when back from vacation. No problem if someone wants to
pick it up earlier. We'd need to exclude generated protobuf files in the hbase-protocol and
hbase-rest modules in the Javac+error prone compile target and include only them in the Javac-only
compile target. After that it should work. Then we will have warnings to fix. Those could
be addressed in a separate issue although I rolled them in here previously. 

> Catch some bad practices at compile time with error-prone
> ---------------------------------------------------------
>                 Key: HBASE-11912
>                 URL: https://issues.apache.org/jira/browse/HBASE-11912
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Andrew Purtell
>         Attachments: HBASE-11912.patch, HBASE-11912.patch
> Google's error-prone (https://code.google.com/p/error-prone/) wraps javac with some additional
static analysis that will generate additional warnings or errors at compile time if certain
bug patterns (https://code.google.com/p/error-prone/wiki/BugPatterns) are detected. What's
nice about this approach, as opposed to findbugs, is the compile time detection and erroring
out prevent the detected problems from getting into the codebase up front.

This message was sent by Atlassian JIRA

View raw message