hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11879) Change TableInputFormatBase to take interface arguments
Date Wed, 01 Oct 2014 06:39:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154450#comment-14154450
] 

Hudson commented on HBASE-11879:
--------------------------------

FAILURE: Integrated in HBase-TRUNK #5596 (See [https://builds.apache.org/job/HBase-TRUNK/5596/])
HBASE-11879 Change TableInputFormatBase to take interface arguments (Solomon Duskis) (stack:
rev ff31691c84587c2fc938705e184f2a3238ef3070)
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReader.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatBase.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java


> Change TableInputFormatBase to take interface arguments
> -------------------------------------------------------
>
>                 Key: HBASE-11879
>                 URL: https://issues.apache.org/jira/browse/HBASE-11879
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Carter
>            Assignee: Solomon Duskis
>             Fix For: 2.0.0, 0.99.1
>
>         Attachments: 11879v4.txt, HBASE-11879_v2.patch, HBASE-11879_v3.patch, HBASE_11879.patch,
HBASE_11879_v1.patch
>
>
> As part of the ongoing interface abstraction work, I'm now investigating {{TableInputFormatBase}},
which has two methods that break encapsulation:
> {code}
> protected HTable getHTable();
> protected void setHTable(HTable table);
> {code}
> While these are protected methods, the base @InterfaceAudience.Public is abstract, meaning
that it supports extension by user code.
> I propose deprecating these two methods and replacing them with these four, once the
Table interface is merged:
> {code}
> protected Table getTable();
> protected void setTable(Table table);
> protected RegionLocator getRegionLocator();
> protected void setRegionLocator(RegionLocator regionLocator);
> {code}
> Since users will frequently call {{setTable}} and {{setRegionLocator}} together, it probably
also makes sense to add the following convenience method:
> {code}
> protected void setTableAndRegionLocator(Table table, RegionLocator regionLocator);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message