hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11815) Flush and compaction could just close the tmp writer if there is an exception
Date Tue, 07 Oct 2014 06:26:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161536#comment-14161536
] 

Hudson commented on HBASE-11815:
--------------------------------

FAILURE: Integrated in HBase-TRUNK #5627 (See [https://builds.apache.org/job/HBase-TRUNK/5627/])
HBASE-11815 Flush and compaction could just close the tmp writer if there (ramkrishna: rev
eb6f196395b4462ebabbaf1049d919533ae1875f)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFlusher.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactor.java


> Flush and compaction could just close the tmp writer if there is an exception
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-11815
>                 URL: https://issues.apache.org/jira/browse/HBASE-11815
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Trivial
>             Fix For: 2.0.0, 0.98.7, 0.99.1
>
>         Attachments: HBASE-11815.patch, HBASE-11815_0.98.patch, HBASE-11815_1.patch,
HBASE-11815_2.patch, HBASE-11815_2.patch
>
>
> A minor change.
> {code}
>         try {
>           flushed = performFlush(scanner, writer, smallestReadPoint);
>         } finally {
>           finalizeWriter(writer, cacheFlushId, status);
>         }
> {code}
> Whenever there is a failure during flush we should close the writer but adding the meta
data and setting the status would not be needed.
> {code}
>     status.setStatus("Flushing " + store + ": appending metadata");
>     writer.appendMetadata(cacheFlushSeqNum, false);
>     status.setStatus("Flushing " + store + ": closing flushed file");
>     writer.close();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message