hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Manukranth Kolloju (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8936) Fixing TestSplitLogWorker while running Jacoco tests.
Date Wed, 08 Oct 2014 18:21:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163910#comment-14163910
] 

Manukranth Kolloju commented on HBASE-8936:
-------------------------------------------

I checked the other places where we use clazz.getDeclaredFields(). Seems like we use it in
the following places : 
MetricSourceBuilder : The type/annotation is checked here, so no verification whether its
synthetic is required. 
SequenceFileWriter : There is check to make sure that the field name is "out". So, we don't
need the isSynthetic check there.
ClassSize : The static fields are ignored, so its ok.

In general it seems like a good idea to check whether fields are synthetic before going any
further using Reflection.

> Fixing TestSplitLogWorker while running Jacoco tests.
> -----------------------------------------------------
>
>                 Key: HBASE-8936
>                 URL: https://issues.apache.org/jira/browse/HBASE-8936
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.89-fb
>            Reporter: Manukranth Kolloju
>            Assignee: Manukranth Kolloju
>            Priority: Trivial
>             Fix For: 0.89-fb, 2.0.0, 0.98.8, 0.99.1
>
>         Attachments: 0001-Fix-failures-caused-by-Jacoco-syncthetic-methods.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Jacoco adds a synthetic field and a synthetic method in the classes for capturing the
execution data. So, in SplitLogCounters, while resetting the fields we need to avoid these
synthetic fields.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message