Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 29 Sep 2014 04:07:34 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12744453.1411784112000.143206.1411963654603@Atlassian.JIRA>
In-Reply-To: <JIRA.12744453.1411784112000@Atlassian.JIRA>
References: <JIRA.12744453.1411784112000@Atlassian.JIRA>
 <JIRA.12744453.1411784112967@arcas>
Subject: [jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue
 some more simple cases
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151339#comment-14151339 ] 

stack commented on HBASE-12112:
-------------------------------

ok on the toJSON.  Expensive -- espcially when it is subsequently json'ized -- but makes sense.  Ok on the rawcells.  Maybe comment that no iterator is made in this case.   Otherwise all good by me.

> Avoid KeyValueUtil#ensureKeyValue some more simple cases
> --------------------------------------------------------
>
>                 Key: HBASE-12112
>                 URL: https://issues.apache.org/jira/browse/HBASE-12112
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0, 0.99.1
>
>         Attachments: HBASE-12112.patch
>
>
> This include fixes with
> - Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell)
> - Printing the key portion of a cell (rk+cf+q+ts+type). These are in Exception messages
> - HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to cell#getxxx() which involves bytes copying. This is not a hot area still we can avoid as much usage of deprecated methods as possible in core code. I believe these bytes copying methods are used in many other parts and later we can try fixing those as per area importance
> - Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)