Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DCD7911DA7 for ; Wed, 24 Sep 2014 17:17:34 +0000 (UTC) Received: (qmail 67056 invoked by uid 500); 24 Sep 2014 17:17:34 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 67005 invoked by uid 500); 24 Sep 2014 17:17:34 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 66994 invoked by uid 99); 24 Sep 2014 17:17:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Sep 2014 17:17:34 +0000 Date: Wed, 24 Sep 2014 17:17:34 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-12077) FilterLists create many ArrayList$Itr objects per row. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-12077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146552#comment-14146552 ] stack commented on HBASE-12077: ------------------------------- Crazy this makes for so much savings. How we make it so new code does not revert? The check on patch build sounds good though could get annoying if not an arraylist. Can we at least add to the refguide in dev section? And then cite it on any violation seen in review? Any other suggestions for educating devs? > FilterLists create many ArrayList$Itr objects per row. > ------------------------------------------------------ > > Key: HBASE-12077 > URL: https://issues.apache.org/jira/browse/HBASE-12077 > Project: HBase > Issue Type: Sub-task > Reporter: Lars Hofhansl > Assignee: Lars Hofhansl > Fix For: 2.0.0, 0.98.7, 0.94.24, 0.99.1 > > Attachments: 12077-0.98.txt, HBASE-12077.patch > > > Almost all methods in FilterList do work on behalf of the passed list of filters, which - you guessed it - is always an ArrayList and we always iterate over those with an iterator. Multiple of these methods are called for each row leading to creating about 10 Itrs for every single row touched (whether filtered or not) -- This message was sent by Atlassian JIRA (v6.3.4#6332)