Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A00AA11C0B for ; Tue, 23 Sep 2014 17:48:35 +0000 (UTC) Received: (qmail 64046 invoked by uid 500); 23 Sep 2014 17:48:34 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 64001 invoked by uid 500); 23 Sep 2014 17:48:34 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 63902 invoked by uid 99); 23 Sep 2014 17:48:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Sep 2014 17:48:34 +0000 Date: Tue, 23 Sep 2014 17:48:34 +0000 (UTC) From: "Nick Dimiduk (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-12061) Ensure LOG.isXXXEnabled() wrapper around LOG.XXX() calls MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-12061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145115#comment-14145115 ] Nick Dimiduk commented on HBASE-12061: -------------------------------------- Could this be broken out into a couple critical path commits, or by package? Rolling back such a big commit down the road (for whatever reason) sounds like a painfully manual process. > Ensure LOG.isXXXEnabled() wrapper around LOG.XXX() calls > -------------------------------------------------------- > > Key: HBASE-12061 > URL: https://issues.apache.org/jira/browse/HBASE-12061 > Project: HBase > Issue Type: Sub-task > Components: Performance > Reporter: Vladimir Rodionov > Assignee: Vladimir Rodionov > > The common anti-pattern in Java is using LOG.xxx() calls w/o wrapping them into LOG.isXXXEnabled(). This results in unnecessary object serializations/ string concatenations/ garbage object production even if XXX log level is disabled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)