Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AB1F711865 for ; Tue, 9 Sep 2014 23:05:30 +0000 (UTC) Received: (qmail 29716 invoked by uid 500); 9 Sep 2014 23:05:29 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 29659 invoked by uid 500); 9 Sep 2014 23:05:29 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 29584 invoked by uid 99); 9 Sep 2014 23:05:29 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Sep 2014 23:05:29 +0000 Date: Tue, 9 Sep 2014 23:05:29 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-11923) Potential race condition in RecoverableZookeeper.checkZk() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127742#comment-14127742 ] Andrew Purtell commented on HBASE-11923: ---------------------------------------- +1 > Potential race condition in RecoverableZookeeper.checkZk() > ---------------------------------------------------------- > > Key: HBASE-11923 > URL: https://issues.apache.org/jira/browse/HBASE-11923 > Project: HBase > Issue Type: Sub-task > Reporter: Lars Hofhansl > Assignee: Lars Hofhansl > Fix For: 0.99.0, 2.0.0, 0.98.7, 0.94.24 > > Attachments: 11923-trunk.txt > > > [~apurtell] pointed out a potential race condition in RecoverableZookeeper.checkZk() that I introduced in parent. > If multiple threads would enter that method at the same time without a valid Zookeeper reference, we could leak Zookeeper objects. > Since this is not a on a hot code path we should just synchronize the two involved methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)