Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E6F14114C6 for ; Thu, 25 Sep 2014 11:39:34 +0000 (UTC) Received: (qmail 36173 invoked by uid 500); 25 Sep 2014 11:39:34 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 36077 invoked by uid 500); 25 Sep 2014 11:39:34 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 35848 invoked by uid 99); 25 Sep 2014 11:39:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Sep 2014 11:39:34 +0000 Date: Thu, 25 Sep 2014 11:39:34 +0000 (UTC) From: "Anoop Sam John (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-11920) Add CP hooks for ReplicationEndPoint MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147657#comment-14147657 ] Anoop Sam John commented on HBASE-11920: ---------------------------------------- patch V6 LGTM nit : + * @return the endpoint to use during replication. {@code null} if the default implementation is to + * be used. Pls avoid saying "return null". Return the incoming instance itself is the best way. Just avoid that sentence. > Add CP hooks for ReplicationEndPoint > ------------------------------------ > > Key: HBASE-11920 > URL: https://issues.apache.org/jira/browse/HBASE-11920 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors, Replication > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 0.99.1 > > Attachments: HBASE-11920.patch, HBASE-11920_1.patch, HBASE-11920_2.patch, HBASE-11920_3.patch, HBASE-11920_4.patch, HBASE-11920_6.patch > > > If we want to create internal replication endpoints other than the one created thro configuration we may need new hooks. This is something like an internal scanner that we create during compaction so that the actual compaction scanner can be used as a delegator. > [~enis] > If I can give a patch by tomorrow will it be possible to include in the RC? -- This message was sent by Atlassian JIRA (v6.3.4#6332)