Return-Path: 
 <issues-return-161185-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 5A54E114F5
	for <apmail-hbase-issues-archive@www.apache.org>;
 Tue,  9 Sep 2014 21:17:30 +0000 (UTC)
Received: (qmail 62633 invoked by uid 500); 9 Sep 2014 21:17:30 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 62593 invoked by uid 500); 9 Sep 2014 21:17:30 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 62579 invoked by uid 99); 9 Sep 2014 21:17:30 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Sep 2014 21:17:30 +0000
Date: Tue, 9 Sep 2014 21:17:30 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12740076.1410246836000.31529.1410297450053@Atlassian.JIRA>
In-Reply-To: <JIRA.12740076.1410246836000@Atlassian.JIRA>
References: <JIRA.12740076.1410246836000@Atlassian.JIRA>
 <JIRA.12740076.1410246836810@arcas>
Subject: [jira] [Commented] (HBASE-11919) Remove the deprecated pre/postGet
 CP hook
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-11919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127570#comment-14127570 ] 

Hudson commented on HBASE-11919:
--------------------------------

FAILURE: Integrated in HBase-1.0 #167 (See [https://builds.apache.org/job/HBase-1.0/167/])
HBASE-11919 Remove the deprecated pre/postGet CP hook. (anoopsamjohn: rev 3261cb352bfc18bebd4e4ce1ed03e67709402098)
* hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java


> Remove the deprecated pre/postGet CP hook
> -----------------------------------------
>
>                 Key: HBASE-11919
>                 URL: https://issues.apache.org/jira/browse/HBASE-11919
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors, regionserver
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.99.0, 2.0.0
>
>         Attachments: HBASE-11919.patch
>
>
> These hooks, dealing with List<KeyValue>, were deprecated since 0.96. We have 0.98, one more major version after that. Suggest this can be removed from 0.99 time.
> The impl in BaseRegionObserver is as below which can be very inefficient especially when we read from a DBE files. There we return not KeyValue but a new Cell impl (here by avoiding the need to copy value bytes) The KeyValueUtil.ensureKeyValue can kill this nice optimization if we come across this.
> {code}
> public void preGetOp(final ObserverContext<RegionCoprocessorEnvironment> e,
>       final Get get, final List<Cell> results) throws IOException {
>     // By default we are executing the deprecated preGet to support legacy RegionObservers
>     // We may use the results coming in and we may return the results going out.
>     List<KeyValue> kvs = new ArrayList<KeyValue>(results.size());
>     for (Cell c : results) {
>       kvs.add(KeyValueUtil.ensureKeyValue(c));
>     }
>     preGet(e, get, kvs);
>     results.clear();
>     results.addAll(kvs);
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)