Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 46A2611DE2 for ; Tue, 2 Sep 2014 13:24:21 +0000 (UTC) Received: (qmail 50541 invoked by uid 500); 2 Sep 2014 13:24:21 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 50484 invoked by uid 500); 2 Sep 2014 13:24:21 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 50471 invoked by uid 99); 2 Sep 2014 13:24:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Sep 2014 13:24:20 +0000 Date: Tue, 2 Sep 2014 13:24:20 +0000 (UTC) From: "Jean-Marc Spaggiari (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-11877) Make TableSplit more readable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118184#comment-14118184 ] Jean-Marc Spaggiari commented on HBASE-11877: --------------------------------------------- Don't see any issue with that. Have you ran it locally? Do you have a copy of the output? Has it passed the tests? Not anyrisk for those new fields (m_tableName, m_regionLocation) to be null? I don't think so, but just asking. > Make TableSplit more readable > ----------------------------- > > Key: HBASE-11877 > URL: https://issues.apache.org/jira/browse/HBASE-11877 > Project: HBase > Issue Type: Improvement > Affects Versions: 2.0.0 > Reporter: Liu Shaohui > Assignee: Liu Shaohui > Priority: Minor > Attachments: HBASE-11877-trunk-v1.diff > > > When debugging MR jobs reading from hbase table, it's import to figure out which region a map task is reading from. > But the table split object is hard to read. > eg: > {code} > 2014-09-01 20:58:39,783 INFO [main] org.apache.hadoop.mapred.MapTask: Processing split: lg-hadoop-prc-st40.bj:,0 > {code} > See: TableSplit.java > {code} > @Override > public String toString() { > return m_regionLocation + ":" + > Bytes.toStringBinary(m_startRow) + "," + Bytes.toStringBinary(m_endRow); > } > {code} > We should make it more readable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)