Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6120511144 for ; Wed, 3 Sep 2014 19:40:54 +0000 (UTC) Received: (qmail 10013 invoked by uid 500); 3 Sep 2014 19:40:52 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 9919 invoked by uid 500); 3 Sep 2014 19:40:52 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 9645 invoked by uid 99); 3 Sep 2014 19:40:52 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Sep 2014 19:40:52 +0000 Date: Wed, 3 Sep 2014 19:40:52 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-11876) RegionScanner.nextRaw(...) should not update metrics MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120310#comment-14120310 ] Hudson commented on HBASE-11876: -------------------------------- FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #467 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/467/]) Revert "HBASE-11876 RegionScanner.nextRaw should not update metrics" (apurtell: rev c3882ed73a5c77c21ee5110ded9598f2f317cb55) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java HBASE-11876 RegionScanner.nextRaw should not update metrics (apurtell: rev cf843b196338cf2f2bd0eafbe88fda7d4386fba2) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > RegionScanner.nextRaw(...) should not update metrics > ---------------------------------------------------- > > Key: HBASE-11876 > URL: https://issues.apache.org/jira/browse/HBASE-11876 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.6 > Reporter: Lars Hofhansl > Assignee: Andrew Purtell > Fix For: 0.99.0, 2.0.0, 0.98.6 > > Attachments: HBASE-11876-0.98.patch, HBASE-11876-0.98.patch, HBASE-11876.patch, HBASE-11876.patch > > > I added the RegionScanner.nextRaw(...) to allow "smart" client to avoid some of the default work that HBase is doing, such as {start|stop}RegionOperation and synchronized(scanner) for each row. > Metrics should follow the same approach. Collecting them per row is expensive and a caller should have the option to collect those later or to avoid collecting them completely. > We can also save some cycles in RSRcpServices.scan(...) if we updated the metric only once/batch instead of each row. -- This message was sent by Atlassian JIRA (v6.3.4#6332)