Return-Path: 
 <issues-return-160639-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 6E34E113AA
	for <apmail-hbase-issues-archive@www.apache.org>;
 Sat,  6 Sep 2014 09:40:29 +0000 (UTC)
Received: (qmail 5560 invoked by uid 500); 6 Sep 2014 09:40:29 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 5512 invoked by uid 500); 6 Sep 2014 09:40:29 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 5500 invoked by uid 99); 6 Sep 2014 09:40:29 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Sep 2014 09:40:29 +0000
Date: Sat, 6 Sep 2014 09:40:29 +0000 (UTC)
From: "Anoop Sam John (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12736121.1408731865000.9389.1409996429160@Atlassian.JIRA>
In-Reply-To: <JIRA.12736121.1408731865000@Atlassian.JIRA>
References: <JIRA.12736121.1408731865000@Atlassian.JIRA>
 <JIRA.12736121.1408731865600@arcas>
Subject: [jira] [Commented] (HBASE-11805) KeyValue to Cell Convert in
 WALEdit APIs
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14124406#comment-14124406 ] 

Anoop Sam John commented on HBASE-11805:
----------------------------------------

[~apurtell]
{code}
+@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.COPROC)
 public class WALEdit implements Writable, HeapSize {{code}
The Jira adding the annotations is in now. WALEdit is still private. But it is exposed to CPs via different hooks. So I am changing it to LimitedPrivate for COPROC

V3 patch solves comments from Ram and Stack. Will commit tomorrow unless objections.  Hope you ok [~enis]

> KeyValue to Cell Convert in WALEdit APIs
> ----------------------------------------
>
>                 Key: HBASE-11805
>                 URL: https://issues.apache.org/jira/browse/HBASE-11805
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.99.0, 2.0.0, 0.98.7
>
>         Attachments: HBASE-11805.patch, HBASE-11805_0.98.patch, HBASE-11805_0.98_V2.patch, HBASE-11805_0.99.patch, HBASE-11805_V2.patch, HBASE-11805_V3.patch
>
>
> In almost all other main interface class/APIs we have changed KeyValue to Cell. But missing in WALEdit. This is public marked for Replication (Well it should be for CP also) 
> These 2 APIs deal with KVs
> add(KeyValue kv)
> ArrayList<KeyValue> getKeyValues()
> Suggest deprecate them and add for 0.98
> add(Cell kv) 
> List<Cell> getCells()
> And just replace from 1.0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)