Return-Path: 
 <issues-return-160483-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 6AA27112E1
	for <apmail-hbase-issues-archive@www.apache.org>;
 Fri,  5 Sep 2014 05:21:26 +0000 (UTC)
Received: (qmail 625 invoked by uid 500); 5 Sep 2014 05:21:26 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 585 invoked by uid 500); 5 Sep 2014 05:21:26 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 570 invoked by uid 99); 5 Sep 2014 05:21:26 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Sep 2014 05:21:26 +0000
Date: Fri, 5 Sep 2014 05:21:25 +0000 (UTC)
From: "ramkrishna.s.vasudevan (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12736121.1408731865000.3747.1409894485940@Atlassian.JIRA>
In-Reply-To: <JIRA.12736121.1408731865000@Atlassian.JIRA>
References: <JIRA.12736121.1408731865000@Atlassian.JIRA>
 <JIRA.12736121.1408731865600@arcas>
Subject: [jira] [Commented] (HBASE-11805) KeyValue to Cell Convert in
 WALEdit APIs
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14122453#comment-14122453 ] 

ramkrishna.s.vasudevan commented on HBASE-11805:
------------------------------------------------

There are codes like this
{code}
    while (kvs.size() < expectedCount && cellDecoder.advance()) {
      Cell cell = cellDecoder.current();
      if (!(cell instanceof KeyValue)) {
        throw new IOException("WAL edit only supports KVs as cells");
      }
      kvs.add((KeyValue)cell);
    }
{code}
We may need to check these places. Discussing wth Anoop here, if we try to work with cells and try using cells in walEdit unless the codec in the replication is changed to work with Cells we don't get the real benefit of Cells in waledit. But it is always right to change all our data structures to deal with Cells rather than Kvs.

> KeyValue to Cell Convert in WALEdit APIs
> ----------------------------------------
>
>                 Key: HBASE-11805
>                 URL: https://issues.apache.org/jira/browse/HBASE-11805
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.99.0, 2.0.0, 0.98.7
>
>         Attachments: HBASE-11805.patch, HBASE-11805_0.98.patch, HBASE-11805_V2.patch
>
>
> In almost all other main interface class/APIs we have changed KeyValue to Cell. But missing in WALEdit. This is public marked for Replication (Well it should be for CP also) 
> These 2 APIs deal with KVs
> add(KeyValue kv)
> ArrayList<KeyValue> getKeyValues()
> Suggest deprecate them and add for 0.98
> add(Cell kv) 
> List<Cell> getCells()
> And just replace from 1.0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)