hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
Date Tue, 30 Sep 2014 08:40:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152962#comment-14152962

Anoop Sam John commented on HBASE-12112:

HBASE-3211 added this Filter. Any specific reason to add this boolean param?
bq.Make it a noop? That filters use of the flag is odd.
Any way that can be a different issue I think. There we have to deprecate the constructor
taking the boolean( deprecate in 1.0 and remove in 2.0?).  Also along with that I can do optimization.
Now we can have Cells in read path and no need to recreate a KV and copy key part for returning
from this filter transform().  If the boolean can be removed that still easier.  I can have
a new Cell impl (CellKey itself?) and no need for bytes copy.   I can do all these in a follow
on issue?

> Avoid KeyValueUtil#ensureKeyValue some more simple cases
> --------------------------------------------------------
>                 Key: HBASE-12112
>                 URL: https://issues.apache.org/jira/browse/HBASE-12112
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0, 0.99.1
>         Attachments: HBASE-12112.patch, HBASE-12112_V2.patch, HBASE-12112_V2.patch
> This include fixes with
> - Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell)
> - Printing the key portion of a cell (rk+cf+q+ts+type). These are in Exception messages
> - HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to cell#getxxx() which
involves bytes copying. This is not a hot area still we can avoid as much usage of deprecated
methods as possible in core code. I believe these bytes copying methods are used in many other
parts and later we can try fixing those as per area importance
> - Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter

This message was sent by Atlassian JIRA

View raw message