hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
Date Mon, 29 Sep 2014 16:18:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151859#comment-14151859

stack commented on HBASE-12112:

CellKey would replace places where we make a Cell with a null value.  I think that makes sense.

Add a class comment on CellKey on commit on what it is for.

Change this on commit to be getCellKey:

public static CellKey getKey(Cell cell){

Still need this even though you just added CellKey?

public static Cell createKeyOnlyCell(Cell c, boolean lenAsVal) {

In hfile v2 and v3 where you convert cell to be a cellkey just so you can toString it, its
'clean' but expensive.  I suppose it is fine.  Ignore this remark.

+1 on commit. Nice.

> Avoid KeyValueUtil#ensureKeyValue some more simple cases
> --------------------------------------------------------
>                 Key: HBASE-12112
>                 URL: https://issues.apache.org/jira/browse/HBASE-12112
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0, 0.99.1
>         Attachments: HBASE-12112.patch, HBASE-12112_V2.patch, HBASE-12112_V2.patch
> This include fixes with
> - Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell)
> - Printing the key portion of a cell (rk+cf+q+ts+type). These are in Exception messages
> - HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to cell#getxxx() which
involves bytes copying. This is not a hot area still we can avoid as much usage of deprecated
methods as possible in core code. I believe these bytes copying methods are used in many other
parts and later we can try fixing those as per area importance
> - Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter

This message was sent by Atlassian JIRA

View raw message