hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
Date Sat, 27 Sep 2014 15:32:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150641#comment-14150641

Anoop Sam John commented on HBASE-12112:

bq.In CellComparator is there something that does the below? If not, should we add it?
Yes. Thanks.. I can use it. That will be better.
bq.ClonedSeekerState is serializing same way KV did? that is why the heapsize calc works?
The fixed over head is different from KV. The dynamic part is the lengths of individual components
bq. Are we perpetuating the old KV serialization surrepticiously here? 
It is just used in some Exception messages and toString impls. I think better we can change
these places to have some thing like 
rk :<rk> cf: <f> q: <q> ts type message. No need to create the key as it
would look like in KV. I was just trying to be like the old way. I can chage. Sounds good?
bq.This thing is kinda crazy cellToStringMap (Its not you, you are just replacing what was
there). Is that necessary?
Again was trying to be like the old way. This is used by toJSON() and you can see Scan/Get
etc also implements it with adding their details. I think we can continue to have this.

> Avoid KeyValueUtil#ensureKeyValue some more simple cases
> --------------------------------------------------------
>                 Key: HBASE-12112
>                 URL: https://issues.apache.org/jira/browse/HBASE-12112
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0, 0.99.1
>         Attachments: HBASE-12112.patch
> This include fixes with
> - Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell)
> - Printing the key portion of a cell (rk+cf+q+ts+type). These are in Exception messages
> - HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to cell#getxxx() which
involves bytes copying. This is not a hot area still we can avoid as much usage of deprecated
methods as possible in core code. I believe these bytes copying methods are used in many other
parts and later we can try fixing those as per area importance
> - Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter

This message was sent by Atlassian JIRA

View raw message