hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12077) FilterLists create many ArrayList$Itr objects per row.
Date Wed, 24 Sep 2014 17:35:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146582#comment-14146582

Andrew Purtell commented on HBASE-12077:

bq. Can we at least add to the refguide in dev section? And then cite it on any violation
seen in review? 

We should but we're not going to be consistent if we have a lot of little rules.

bq. How we make it so new code does not revert? The check on patch build sounds good though
could get annoying if not an arraylist. 

A crazy suggestion, but have a look at HBASE-11912. error-prone is ASL 2.0 and pluggable.
We could write our own static analyses. 

> FilterLists create many ArrayList$Itr objects per row.
> ------------------------------------------------------
>                 Key: HBASE-12077
>                 URL: https://issues.apache.org/jira/browse/HBASE-12077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 2.0.0, 0.98.7, 0.94.24, 0.99.1
>         Attachments: 12077-0.98.txt, HBASE-12077.patch
> Almost all methods in FilterList do work on behalf of the passed list of filters, which
- you guessed it - is always an ArrayList and we always iterate over those with an iterator.
Multiple of these methods are called for each row leading to creating about 10 Itrs for every
single row touched (whether filtered or not)

This message was sent by Atlassian JIRA

View raw message