hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12077) FilterLists create many ArrayList$Itr objects per row.
Date Wed, 24 Sep 2014 17:17:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146552#comment-14146552
] 

stack commented on HBASE-12077:
-------------------------------

Crazy this makes for so much savings. How we make it so new code does not revert?  The check
on patch build sounds good though could get annoying if not an arraylist.  Can we at least
add to the refguide in dev section?  And then cite it on any violation seen in review?  Any
other suggestions for educating devs?

> FilterLists create many ArrayList$Itr objects per row.
> ------------------------------------------------------
>
>                 Key: HBASE-12077
>                 URL: https://issues.apache.org/jira/browse/HBASE-12077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 2.0.0, 0.98.7, 0.94.24, 0.99.1
>
>         Attachments: 12077-0.98.txt, HBASE-12077.patch
>
>
> Almost all methods in FilterList do work on behalf of the passed list of filters, which
- you guessed it - is always an ArrayList and we always iterate over those with an iterator.
Multiple of these methods are called for each row leading to creating about 10 Itrs for every
single row touched (whether filtered or not)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message