hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12061) Ensure LOG.isXXXEnabled() wrapper around LOG.XXX() calls
Date Tue, 23 Sep 2014 19:05:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145260#comment-14145260
] 

Andrew Purtell commented on HBASE-12061:
----------------------------------------

I don't think we would ever turn off WARN level logging. I've run with INFO level logging
off before in production to manage log growth. There are alternative ways to achieve that
end of course.

> Ensure LOG.isXXXEnabled() wrapper around LOG.XXX() calls
> --------------------------------------------------------
>
>                 Key: HBASE-12061
>                 URL: https://issues.apache.org/jira/browse/HBASE-12061
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Performance
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>
> The common anti-pattern in Java is using LOG.xxx() calls w/o wrapping them into LOG.isXXXEnabled().
This results in unnecessary object serializations/ string concatenations/ garbage object production
even if XXX log level is disabled.   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message