hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12061) Ensure LOG.isXXXEnabled() wrapper around LOG.XXX() calls
Date Tue, 23 Sep 2014 18:36:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145203#comment-14145203
] 

Enis Soztutar commented on HBASE-12061:
---------------------------------------

I think the practice we try to follow so far was use wrappers for DEBUG, and TRACE calls,
but not for INFO or any level higher. The assumption is that mostly INFO level or WARN level
is on anyways. Do we want to do the wrapper for every level?  

> Ensure LOG.isXXXEnabled() wrapper around LOG.XXX() calls
> --------------------------------------------------------
>
>                 Key: HBASE-12061
>                 URL: https://issues.apache.org/jira/browse/HBASE-12061
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Performance
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>
> The common anti-pattern in Java is using LOG.xxx() calls w/o wrapping them into LOG.isXXXEnabled().
This results in unnecessary object serializations/ string concatenations/ garbage object production
even if XXX log level is disabled.   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message