hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashish Singhi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12060) Replace enhanced for statement with basic for statement where possible
Date Tue, 23 Sep 2014 14:29:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144834#comment-14144834

Ashish Singhi commented on HBASE-12060:

There are around 4000 for loops in trunk source code.

I was thinking whether is it possible to divide this jira into sub task module wise to avoid
rebase of patch if someone commits something into the trunk code and also reviewer will be
able to review easily.
Also we can take up critical module first and then the rest.

> Replace enhanced for statement with basic for statement where possible
> ----------------------------------------------------------------------
>                 Key: HBASE-12060
>                 URL: https://issues.apache.org/jira/browse/HBASE-12060
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Andrew Purtell
>              Labels: beginner, beginners
> Wherever we use the enhanced for construction:
> {noformat}
>     for ( FormalParameter : Expression ) Statement
> {noformat}
> where the Expression evaluates to an array or collection type that supports random access,
we can avoid creating iterator objects, unless we are also using the iterator to remove items
while iterating by using the basic for statement instead:
> {noformat}
> for ( ForInit ; Expression ; ForUpdate ) Statement
> {noformat}

This message was sent by Atlassian JIRA

View raw message