hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12048) Remove deprecated APIs from Filter
Date Mon, 22 Sep 2014 18:44:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143607#comment-14143607
] 

Anoop Sam John commented on HBASE-12048:
----------------------------------------

bq.If most of the Filter's do not implement transform, they won't be affected?
Most of the Filters do not implement transformCell(Cell). That is the issue now. The core
code flow calls transformCell on filter. And as they don't have specific impl, the one from
FilterBase will get called which will convert the cell to KV and delegate call to transform(KeyValue).
 Again this also from FilterBase  only will get executed (mostly) which do nothing.   So if
we can not remove these methods from Filter for 1.0, as a workaround we can implement transformCell(Cell)
in our existing Filters.(as just return the incoming cell)

> Remove deprecated APIs from Filter
> ----------------------------------
>
>                 Key: HBASE-12048
>                 URL: https://issues.apache.org/jira/browse/HBASE-12048
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0, 0.99.1
>
>         Attachments: HBASE-12048.patch, HBASE-12048_V2.patch
>
>
> To be removed
> KeyValue transform(final KeyValue currentKV)
> KeyValue getNextKeyHint(final KeyValue currentKV)
> These are deprecated since 0.96 and can get removed from 1.0 time.
> Any objections?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message