hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12048) Remove deprecated APIs from Filter
Date Mon, 22 Sep 2014 17:36:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143488#comment-14143488
] 

Anoop Sam John commented on HBASE-12048:
----------------------------------------

[~ram_krish]
IMO we can remove from 1.0 time.  There were no discussion abt removing these methods from
Filter in HBASE-10930.
Whenever there is a Filter used in Scan, the system will call transformCell(Cell v) . Normally
Filters won't implement this method and so method from FilterBase will be getting used. You
can see a possible KV convert here. In read path the nice optimization done with not copying
the value part in DBE wont get any adv as at this point we will forced to convert to KV and
so key and value copy.  IMO we can aim for Cells only in read/write path in 1.0 itself. We
are very close to that I believe. Correct Ram?

If there is strong objection in removing these KV based APIs from Filter from 1.0, we can
do one thing.  In all in built Filter implementation we can implement transformCell(Cell v)
 just return the cell.  This will avoid the method from FilterBase being executed which might
involve KV recreate.

> Remove deprecated APIs from Filter
> ----------------------------------
>
>                 Key: HBASE-12048
>                 URL: https://issues.apache.org/jira/browse/HBASE-12048
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0, 0.99.1
>
>         Attachments: HBASE-12048.patch
>
>
> To be removed
> KeyValue transform(final KeyValue currentKV)
> KeyValue getNextKeyHint(final KeyValue currentKV)
> These are deprecated since 0.96 and can get removed from 1.0 time.
> Any objections?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message