hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vladimir Rodionov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12023) HRegion.applyFamilyMapToMemstore creates too many iterator objects...
Date Fri, 19 Sep 2014 17:09:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140889#comment-14140889

Vladimir Rodionov commented on HBASE-12023:

What about my comment about not being able to guarantee that the lists passed around are not
guaranteed to be random accessible?
Not a problem, because they just happen to be (in Mutation they are ArrayLists)?

Not sure I am following you here, Lars. List is random accessible, by default ( get(int index)
API). As you mentioned already, in mutations we use ArrayList - not LinkedList. LinkedLIst
is not efficient, but (hopefully) will never be used in HBase on a critical read/write paths.

> HRegion.applyFamilyMapToMemstore creates too many iterator objects...
> ---------------------------------------------------------------------
>                 Key: HBASE-12023
>                 URL: https://issues.apache.org/jira/browse/HBASE-12023
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.5, 0.94.23
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>            Priority: Minor
>             Fix For: 0.94.24
>         Attachments: HBASE-12023-0.94.patch, HBASE-12023.patch, applyFamilyMapToMemstore
> for ... loop (creates iterator) inside another for loop. Produces a lot of garbage. See
attached picture.

This message was sent by Atlassian JIRA

View raw message