hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12018) HRegion.close neglects to close its HLog
Date Thu, 18 Sep 2014 17:58:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14139259#comment-14139259
] 

Enis Soztutar commented on HBASE-12018:
---------------------------------------

HBASE-11983 is very relevant indeed. HRegion has two ways of being constructed, and thus two
ways of being closed. One way is to let HRegion create its own hlog, and the other way is
that it gets it in c.tor. In the former case, HRegion.closeHRegion() should be used to close
the region AND the log. In the latter case, HRegion.close() should be used. I think the former
way is only used in tests, and we should actually get rid of this, and simplify it. 

I think this patch is not applicable, since it closes the RS's logs when closing a region.
A region move will abort the RS I guess. 

> HRegion.close neglects to close its HLog
> ----------------------------------------
>
>                 Key: HBASE-12018
>                 URL: https://issues.apache.org/jira/browse/HBASE-12018
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>         Attachments: HBASE-12018.00-0.98.patch, HBASE-12018.00.patch
>
>
> I found this while diagnosing leaking file handles after test runs in a build of 0.98.
I haven't investigated subsequent branches. Perhaps someone more knowledgeable about region
lifecycle can have a look.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message